Attempt to simplify the PDFFindBar and PDFSidebar constructors
#10123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… moving the `eventBus` parameter from the `options` object This is similar to the format used by a number of other viewer components, and should simplify the `PDFFindBar` initialization slightly.
… moving the `eventBus` parameter from the `options` object and removing the `PDFOutlineViewer` dependency This is similar to the format used by a number of other viewer components, and should simplify the `PDFSidebar` initialization slightly. Furthermore, by using the `eventBus` it's no longer necessary for `PDFSidebar` to have a direct dependency on `PDFOutlineViewer`. There's still room for improvement here, but this patch is at least a start (since it's not clear to me how best to handle the viewers).
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/09fef185c97f914/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/09fef185c97f914/output.txt Total script time: 2.95 mins Published |
timvandermeij
approved these changes
Oct 2, 2018
|
More consistency and fewer dependencies; really nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please refer to the individual commit messages.